Add https support for Druid #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
druid_https
branch
from
96b1260
to
f08d19f
Compare
betodealmeida
approved these changes
Feb 26, 2018
superset/connectors/druid/models.py
Outdated
| @@ -107,24 +107,29 @@ def data(self): | |||
| 'backend': 'druid', | |||
| } | |||
|
|
|||
| @staticmethod | |||
| def get_base_url(host, port): | |||
| if not host.startswith('http'): | |||
There was a problem hiding this comment.
It's unlikely, but this might cause problems if the hostname starts with http, eg, http-server.example.com. I think it's better to use a regex here:
if not re.match('http(s)?://', host):
host = 'http://' + host
|
I think |
mistercrunch
force-pushed
the
druid_https
branch
from
8e9ef14
to
3fbd230
Compare
|
Fixed, mergin' |
| endpoint = ( | ||
| 'http://{obj.coordinator_host}:{obj.coordinator_port}/status' | ||
| ).format(obj=self) | ||
| endpoint = self.get_base_coordinator_url() + '/status' |
There was a problem hiding this comment.
@mistercrunch this is broken, it should use get_base_url() instead.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Add https support for Druid * addressing comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Add https support for Druid * addressing comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4465